Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Private NuGet Feed errors with dotnet new --update-check #11618

Closed
donnie-msft opened this issue Feb 24, 2022 · 7 comments
Closed

[Bug]: Private NuGet Feed errors with dotnet new --update-check #11618

donnie-msft opened this issue Feb 24, 2022 · 7 comments
Labels
Area:Authentication Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Product:dotnet.exe Resolution:External This issue appears to be External to nuget Type:Bug

Comments

@donnie-msft
Copy link
Contributor

NuGet Product Used

dotnet.exe

Product Version

6.0.101

Worked before?

no

Impact

No response

Repro Steps & Context

Feedback ticket: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1460341

Similar to #11169...

For some reason nuget makes multiple calls to the credprovider and every next call starting from 2nd passes IsRetry: true as request argument, which invalidates cached token.

To reproduce:

  1. Clear nuget cache (dotnet nuget locals all -c) and credprovider cache (clear this folder)
  2. Set nuget.config to use exclusively private feed in ADO
  3. dotnet new --uninstall Microsoft.DotNet.Web.Spa.ProjectTemplates (remove template for repro if it's already installed)
  4. Run dotnet new --install Microsoft.DotNet.Web.Spa.ProjectTemplates --interactive
  5. Observe multiple sequential interactive prompts

Verbose Logs

No response

@erdembayar
Copy link
Contributor

I'm trying to understand actual scenario.
I asked questions in internal feedback ticket also pinged in teams. I'll update here if there is new update.

@erdembayar erdembayar self-assigned this Mar 1, 2022
@erdembayar erdembayar removed the WaitingForCustomer Applied when a NuGet triage person needs more info from the OP label Mar 1, 2022
@erdembayar
Copy link
Contributor

erdembayar commented Mar 4, 2022

Everytime, I try to repro I'm getting different kind of errors. Something is broken here.

  1. Sometime Cred provider won't ever trigger.

image

  1. Another time:
    image

Looks like some race condition is happening here.

@SimonCropp
Copy link

same thing occurs for the list command

@kartheekp-ms
Copy link
Contributor

same thing occurs for the list command

This should be fixed in NuGet/NuGet.Client#4794

@kartheekp-ms
Copy link
Contributor

@vlada-shubina - Is this somehow related to dotnet/templating#4278 that is fixed in dotnet/templating#4764 ?

@vlada-shubina
Copy link

@vlada-shubina - Is this somehow related to dotnet/templating#4278 that is fixed in dotnet/templating#4764 ?

yes, it seems the same issue. It was already fixed.

@kartheekp-ms
Copy link
Contributor

Looking at dotnet/templating@c5b2e2f commit, it looks like this fix released in https://dotnet.microsoft.com/en-us/download/dotnet/7.0.

@donnie-msft - I propose to close this issue as external.

@kartheekp-ms kartheekp-ms added Resolution:External This issue appears to be External to nuget Functionality:SDK The NuGet client packages published to nuget.org labels Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Authentication Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Product:dotnet.exe Resolution:External This issue appears to be External to nuget Type:Bug
Projects
None yet
Development

No branches or pull requests

7 participants