Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: using fixed string instead of GUID for *.psmdcp file name #12029

Closed
John0King opened this issue Aug 17, 2022 · 5 comments
Closed

[Feature]: using fixed string instead of GUID for *.psmdcp file name #12029

John0King opened this issue Aug 17, 2022 · 5 comments
Labels

Comments

@John0King
Copy link

John0King commented Aug 17, 2022

NuGet Product(s) Involved

dotnet.exe

The Elevator Pitch

the name change cause _rels/.rels file change, and that also cause .nupkg file change, and for someone who using local folder as nuget source ,
then itcause git keep track the same .nupkg every time you pack it (especially,when <GeneratePackageOnBuild>True<GeneratePackageOnBuild>).

Additional Context and Details

No response

@nkolev92
Copy link
Member

Hey @John0King,

I'm not sure I understand your concern.

Can you let us know what you are trying to achieve and the commands you were running and the effect of the problems you encountered.

@nkolev92 nkolev92 added Triage:NeedsMoreInfo WaitingForCustomer Applied when a NuGet triage person needs more info from the OP and removed Triage:Untriaged labels Aug 17, 2022
@John0King
Copy link
Author

@nkolev92 I want a local folder to be a nuget source (the folder and the .nupkg file need to store in git repo),
but every time I build my project , the *.nupkg is changed , I find all the binaries are unchanged , so I'm looking into to .nupkg.zip , turn's out the onlything change is that the name of the *.psmdcp file and the metadata contains it's name (eg. .rels)

so every time you build the project with option <GeneratePackageOnBuild>True<GeneratePackageOnBuild>) , the *.nupkg file is change (though all the output is not change)

@ghost ghost added WaitingForClientTeam Customer replied, needs attention from client team. Do not apply this label manually. and removed WaitingForCustomer Applied when a NuGet triage person needs more info from the OP labels Aug 18, 2022
@nkolev92
Copy link
Member

Ah, ok, you are looking for deterministic pack.

so every time you build the project with option True) , the *.nupkg file is change (though all the output is not change)

The pack target has up to date checks that work on the same machine.
Cross machine that's not possible at this point.

On the pack topic, it's not just the _rels folder, but also the timestamps of the dlls that affect the zip.

We attempted this at some point and we hit issues.

Duplicate of #8601.

@ghost ghost removed the WaitingForClientTeam Customer replied, needs attention from client team. Do not apply this label manually. label Aug 18, 2022
@nkolev92 nkolev92 added Resolution:Duplicate This issue appears to be a Duplicate of another issue Functionality:Pack WaitingForClientTeam Customer replied, needs attention from client team. Do not apply this label manually. labels Aug 18, 2022
@jeffkl jeffkl removed the WaitingForClientTeam Customer replied, needs attention from client team. Do not apply this label manually. label Jan 19, 2024
@joshudson
Copy link

@nkolev92 : Is it possible to just fix the .pcsdmp file to get a consistent name?

The timestamps are what caused the problem and it's easier to sell diff all the files in the zip file than all but two of them.

@nkolev92
Copy link
Member

@joshudson
I think we can reconsider it.
Upvoting #8601 is probably best since it'd get more attention than this single issue.
Please do share your ideas there.

Not sure when we'd able to get to it, but we'd certainly consider community contributions.
https://github.com/NuGet/NuGet.Client/blob/dev/CONTRIBUTING.md - for proposals.
https://github.com/NuGet/Home/blob/dev/CONTRIBUTING.md - For implementation contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants