Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet config command doesn't check if the key is valid #12345

Open
heng-liu opened this issue Jan 4, 2023 · 0 comments
Open

NuGet config command doesn't check if the key is valid #12345

heng-liu opened this issue Jan 4, 2023 · 0 comments
Labels
Area:Settings NuGet.Config and related issues Priority:2 Issues for the current backlog. Product:NuGet.exe NuGet.exe Type:DCR Design Change Request

Comments

@heng-liu
Copy link
Contributor

heng-liu commented Jan 4, 2023

NuGet.exe config -Set doesn't check if the key is valid.
So if we run NuGet.exe config -Set ABC=abc, the following will be added into NuGet.Config file, even though ABC is not a valid key from config-section

  <config>
    <add key="ABC" value="abc" />
  </config>

Since we're writing a spec of adding new dotnet nuget config command, we will need to discuss if we want to keep dotnet nuget config command consistent with NuGet.exe, or change the NuGet.exe to check the key.

@heng-liu heng-liu added Type:DCR Design Change Request Product:NuGet.exe NuGet.exe Area:Settings NuGet.Config and related issues labels Jan 4, 2023
@jeffkl jeffkl added the Priority:2 Issues for the current backlog. label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Settings NuGet.Config and related issues Priority:2 Issues for the current backlog. Product:NuGet.exe NuGet.exe Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

2 participants