Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NuGet.Packaging.Core #12495

Closed
nkolev92 opened this issue Mar 17, 2023 · 6 comments · Fixed by NuGet/docs.microsoft.com-nuget#3311
Closed

Remove NuGet.Packaging.Core #12495

nkolev92 opened this issue Mar 17, 2023 · 6 comments · Fixed by NuGet/docs.microsoft.com-nuget#3311
Assignees
@nkolev92
Labels
Category:BreakingChange Functionality:SDK The NuGet client packages published to nuget.org Partner:CLI-SDK Priority:2 Issues for the current backlog. TechDebt Technical debt Type:DCR Design Change Request
Milestone
6.10

Comments

@nkolev92
Copy link
Member

nkolev92 commented Mar 17, 2023 •
edited
Loading

NuGet Product(s) Affected

dotnet.exe, NuGet SDK

Current Behavior

A long time ago, NuGet.Packaging.Core was merged into NuGet.Packaging.

We added type forwarders to allow certain pre-built tasks from arcade to still work.

We might need to ensure that the .NET SDK can build correct without NuGet.Packaging.Core first before removing it. https://github.com/dotnet/sdk/blob/23bbdf8e62544b04afd333920b109877f427b637/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj#L49

Desired Behavior

NuGet.Packaging.Core is redudant.

Additional Context

No response
@nkolev92 nkolev92 added Type:DCR Design Change Request Triage:Untriaged Functionality:SDK The NuGet client packages published to nuget.org Partner:CLI-SDK and removed Triage:Untriaged labels Mar 17, 2023
@nkolev92
Copy link
Member Author

cc @zivkan

@nkolev92
Copy link
Member Author

Pre-req: dotnet/arcade#12906

@nkolev92 nkolev92 changed the title Stop building NuGet.Packaging.Core Remove NuGet.Packaging.Core Mar 17, 2023
@nkolev92 nkolev92 added the Priority:2 Issues for the current backlog. label Mar 20, 2023
@nkolev92 nkolev92 self-assigned this Mar 20, 2023
@nkolev92 nkolev92 added this to the 7.0 milestone Aug 25, 2023
@nkolev92 nkolev92 mentioned this issue Nov 6, 2023
Merged
@nkolev92
Copy link
Member Author

Idea: Don't publish the package in a minor version and wait for feedback.

@nkolev92 nkolev92 mentioned this issue Apr 10, 2024
Closed
@nkolev92
Copy link
Member Author

  • Don't publish NuGet.Packaging.Core 6.10 to nuget.org (and wait for feedback).
  • Don't publish NuGet.Packaging.Core to .NET SDK composition (in case it's already building).

@nkolev92
Copy link
Member Author

OmniSharp/omnisharp-roslyn#2610 and dotnet/Open-XML-SDK#1703 still depend on current versions.

@nkolev92 nkolev92 mentioned this issue Apr 11, 2024
Merged
8 tasks
@nkolev92 nkolev92 modified the milestones: 7.0, 6.10 Jun 1, 2024
@nkolev92
Copy link
Member Author

https://www.nuget.org/packages/NuGet.Packaging.Core is deprecated, and 6.10 is not published.

There are no concerns raised by anyone, so I think #13385 can be implemented.

This was referenced Jun 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Category:BreakingChange Functionality:SDK The NuGet client packages published to nuget.org Partner:CLI-SDK Priority:2 Issues for the current backlog. TechDebt Technical debt Type:DCR Design Change Request
Projects
None yet
Milestone
6.10
Development

Successfully merging a pull request may close this issue.

Add NuGet.Packaging.Core removal to the release notes NuGet/docs.microsoft.com-nuget
1 participant
@nkolev92