Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No license shows when clicking the “view license” link of the package “FSharp.Net.Http” in the right penal of PM UI #12660

Closed
v-luzh opened this issue Jun 16, 2023 · 5 comments
Assignees
Labels

Comments

@v-luzh
Copy link

v-luzh commented Jun 16, 2023

NuGet Product Used

Visual Studio Package Management UI

Product Version

NuGet Client Dev\6.7.0.83

Worked before?

No response

Impact

It bothers me. A fix would be nice

Repro Steps & Context

Repro Steps:

  1. Open VS and create a F# Console Application (.Net Framework 4.8.1) project.
  2. Right-click the project in Solution Explorer and select “Manage NuGet Packages…” menu item to open PM UI.
  3. Click “Browse” tab and select the “nuget.org” from Package source drop-down list.
  4. Search the package “FSharp.Net.Http” in the filter and click the package in the package list.
  5. Click the “view license” link of the package “FSharp.Net.Http” in the right penal of PM UI.

Expected:

The license shows correctly.

Actual:

Nothing shows for the license info as below screenshot.
image

Notes:

1.Repro rate: 100%.
2.It is not a regression bug since it reproes on 17.5.4 Preview 1.0 [33530.505.d17.5]+ Dev\6.5.0.154.

Verbose Logs

No response

@agr
Copy link

agr commented Jun 16, 2023

Sounds like a package authoring issue: invalid license URL is specified in the package metadata. It should be brought up to the package author.

@nkolev92 nkolev92 added the Priority:2 Issues for the current backlog. label Jun 19, 2023
@nkolev92
Copy link
Member

@martinrrm Seems like it be related to #12060?

When you work on that can you please confirm if that's the case?
If it is not, please let us know so we can retriage.

@nkolev92 nkolev92 added the Functionality:VisualStudioUI Package Manager UI et al label Jun 19, 2023
@martinrrm
Copy link
Contributor

@nkolev92 This is a package issue, the License link points to https://github.com/frank-fs/frank/raw/master/LICENSE.txt which is not valid, maybe Github did a breaking change to raw files url since other packages with GH url have a different url format

@nkolev92
Copy link
Member

nkolev92 commented Jul 3, 2023

Feel free to close. I totally missed @agr's original comment.

@martinrrm
Copy link
Contributor

Closing since its a package issue, consider opening a bug in the package repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants