Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGetAudit severity bugs #12743

Closed
zivkan opened this issue Jul 13, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5313
Closed

NuGetAudit severity bugs #12743

zivkan opened this issue Jul 13, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5313
Assignees
Labels
Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug
Milestone

Comments

@zivkan
Copy link
Member

zivkan commented Jul 13, 2023

NuGet Product Used

dotnet.exe

Product Version

.NET 8 SDK previews

Worked before?

No response

Impact

I'm unable to use this version

Repro Steps & Context

There are some bugs regarding severity in the .NET 8 previews that introduced NuGetAudit

  1. GitHub advisories are being reported at 1 level lower than they should be. For example, Newtonsoft.Json's advisory should be reported as high severity, but it's being reported as moderate.
  2. The same off-by-1 error means that low severity advisories are never reported.
  3. Similarly, using <NuGetAuditLevel> will filter out the github advisories of that level, since Audit thinks they're a lower severity than they really are.

Verbose Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants