Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PackageVulnerabilityInfo implements Equals incorrectly #12844

Closed
nkolev92 opened this issue Aug 25, 2023 · 1 comment · Fixed by NuGet/NuGet.Client#5376
Closed

PackageVulnerabilityInfo implements Equals incorrectly #12844

nkolev92 opened this issue Aug 25, 2023 · 1 comment · Fixed by NuGet/NuGet.Client#5376
Assignees
@nkolev92
Labels
Area:Protocol Client/Server protocol /code around it Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. RegressionDuringThisVersion A regression which broke since last RTM, and was fixed before the next RTM. Type:Bug
Milestone
6.8

Comments

@nkolev92
Copy link
Member

PackageVulnerabilityInfo calls == to compare 2 VersionRange objects, but == is not implemented for VersionRange.
@nkolev92 nkolev92 added Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug RegressionDuringThisVersion A regression which broke since last RTM, and was fixed before the next RTM. Area:Protocol Client/Server protocol /code around it labels Aug 25, 2023
@nkolev92 nkolev92 self-assigned this Aug 25, 2023
@nkolev92 nkolev92 mentioned this issue Aug 25, 2023
Merged
8 tasks
@nkolev92
Copy link
Member Author

This bug affects #12307.

@zivkan zivkan added this to the 6.8 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Area:Protocol Client/Server protocol /code around it Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. RegressionDuringThisVersion A regression which broke since last RTM, and was fixed before the next RTM. Type:Bug
Projects
None yet
Milestone
6.8
Development

Successfully merging a pull request may close this issue.

Use Equals when comparing VersionRange in the PackageVulnerability Equals method NuGet/NuGet.Client
2 participants
@nkolev92 @zivkan