Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the NuGetOperationType from NuGet.PackageManagement, use NuGetProjectActionType instead #12866

Closed
nkolev92 opened this issue Sep 5, 2023 · 3 comments · Fixed by NuGet/NuGet.Client#5394
Assignees
Labels
Category:BreakingChange Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Milestone

Comments

@nkolev92
Copy link
Member

nkolev92 commented Sep 5, 2023

While working conditional PR updating, I noticed myself doing a lot of duplicated work. See more details for motivation: https://github.com/NuGet/NuGet.Client/compare/dev-nkolev92-conditionalPackageReferenceUpdating?expand=1

For example, I had to do lots of conversions with NuGetProjectActionType and NuGetOperationType.
This is redundant, and makes our code more complicated.

I looked at the references and the only place where the NuGetOperationType is explicitly used is as an API is ActionTelemetryEvent, which is not used a lot.

Consolidating these types simplifies the NuGet code and makes future updates simpler.

@nkolev92 nkolev92 added Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Category:BreakingChange labels Sep 5, 2023
@nkolev92 nkolev92 self-assigned this Sep 5, 2023
@ghost
Copy link

ghost commented Sep 5, 2023

@nkolev92 Issue is missing Type label, remember to add a Type label

@ghost ghost added the missing-required-type The required type label is missing. label Sep 5, 2023
@nkolev92
Copy link
Member Author

nkolev92 commented Sep 5, 2023

Fixed in NuGet/NuGet.Client#5394

@nkolev92 nkolev92 closed this as completed Sep 5, 2023
@ghost
Copy link

ghost commented Sep 5, 2023

@nkolev92 Issue is missing Type label, remember to add a Type label

@nkolev92 nkolev92 added the Type:DCR Design Change Request label Oct 30, 2023
@ghost ghost removed the missing-required-type The required type label is missing. label Oct 30, 2023
@nkolev92 nkolev92 added this to the 6.8 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:BreakingChange Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant