Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonTextWriter allocates a large number strings #13283

Closed
Erarndt opened this issue Mar 1, 2024 · 2 comments · Fixed by NuGet/NuGet.Client#5663
Closed

JsonTextWriter allocates a large number strings #13283

Erarndt opened this issue Mar 1, 2024 · 2 comments · Fixed by NuGet/NuGet.Client#5663
Assignees
@Erarndt
Labels
PerfWins Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Milestone
6.10

Comments

@Erarndt
Copy link

Erarndt commented Mar 1, 2024

There is an unfortunate combination of System.IO.StreamWriter and JsonTextWriter where repeated calls to StreamWriter.NewLine allocate each time.
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

@Erarndt Issue is missing Type label, remember to add a Type label

@dotnet-policy-service dotnet-policy-service bot added the missing-required-type The required type label is missing. label Mar 1, 2024
@Erarndt Erarndt mentioned this issue Mar 1, 2024
Merged
8 tasks
@jeffkl jeffkl added Priority:2 Issues for the current backlog. Type:Bug Tenet:Performance Performance issues PerfWins labels Mar 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the missing-required-type The required type label is missing. label Mar 1, 2024
@jeffkl jeffkl removed Priority:2 Issues for the current backlog. Type:Bug Tenet:Performance Performance issues PerfWins labels Mar 1, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

@Erarndt Issue is missing Type label, remember to add a Type label

@dotnet-policy-service dotnet-policy-service bot added the missing-required-type The required type label is missing. label Mar 1, 2024
@jeffkl jeffkl added the Type:Bug label Mar 4, 2024
@dotnet-policy-service dotnet-policy-service bot removed the missing-required-type The required type label is missing. label Mar 4, 2024
@jeffkl jeffkl added Priority:2 Issues for the current backlog. Tenet:Performance Performance issues PerfWins missing-required-type The required type label is missing. labels Mar 4, 2024
@dotnet-policy-service dotnet-policy-service bot removed the missing-required-type The required type label is missing. label Mar 4, 2024
@kartheekp-ms kartheekp-ms added this to the 6.10 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erarndt Erarndt

Labels
PerfWins Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
6.10
Development

Successfully merging a pull request may close this issue.

Remove allocations from TextWriter.NewLine implementation Erarndt/NuGet.Client
3 participants
@jeffkl @kartheekp-ms @Erarndt