Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Unnecessary construction of LockFileItem.Properties dictionary #13557

Closed
ToddGrun opened this issue Jun 17, 2024 · 1 comment · Fixed by NuGet/NuGet.Client#5861
Closed

PERF: Unnecessary construction of LockFileItem.Properties dictionary #13557

ToddGrun opened this issue Jun 17, 2024 · 1 comment · Fixed by NuGet/NuGet.Client#5861
Labels
Functionality:Restore Tenet:Performance Performance issues Type:Bug
Milestone
6.12

Comments

@ToddGrun
Copy link

NuGet Product Used

Other/NA

Product Version

VS17

Worked before?

N/A

Impact

Other

Repro Steps & Context

See NuGet/NuGet.Client#5861 for more details

Open VS
Wait for things to calm down
Start profiling
Open Roslyn.sln, open a file it none opened
Wait for things to calm down
Stop profiling

Verbose Logs

No response
@ToddGrun ToddGrun mentioned this issue Jun 17, 2024
Merged
8 tasks
@ToddGrun
Copy link
Author

PR merged

@zivkan zivkan added this to the 6.12 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Functionality:Restore Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
6.12
Development

Successfully merging a pull request may close this issue.

Defer LockFileItem.Properties dictionary construction until needed ToddGrun/NuGet.Client
3 participants
@nkolev92 @zivkan @ToddGrun