Adding clear cache button to VS package manager settings

[mishra14]

Using this issue to track and get UI feedback for the clear cache button to be added into VS package manager settings page.

[mishra14]

@harikmenon @yishaigalatzer @rrelyea : Let me know if this looks fine.

Thanks

[alpaix]

@harikmenon Do you think we need to emit telemetry events on errors here as well?

[harikmenon]

Yes, we should. We should create an Event Called NuGet Commands or something similar to track this.

[harikmenon]

Is there a spec for this?

[mishra14]

@harikmenon :
Spec for button
Spec for related work on dotnet nuget locals

[harikmenon]

One change we should do is get rid of the confirmation box. If it succeeds, we should just add a text and icon below the button stating the success/failure of the operation. Modal dialog on top of modal dialog is not a good design IMO.

Something like.

Success: NuGet caches cleared successfully at {DateTime}

Failure: Unable to clear NuGet cache at {DateTime}. + Any workarounds that might fix this?

In addition to this, we should instrument this.

Lets create a new NuGetVSCommands event and a property called VS.NuGet.CommandName and fire it every time someone clicks on the button.

I can work with you in person for more specific details.

[mishra14]

Based on offline discussion, i will remove dialog and add messages under the button and a webpage link to better handle errors. Updating the spec for this.

[mishra14]

Updated UI - spec link

[harikmenon]

Looks good. Minor feedback.

Th button and the last option has a huge gap, make it consistent with the size of the current groups.

The link to the doc should be a hyperlink not text.

[mishra14]

Updated :

[harikmenon]

LGTM

[mishra14]

Merged : NuGet/NuGet.Client#829