Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when Powershell language mode is not full language #3326

Open
zhili1208 opened this issue Aug 16, 2016 · 2 comments
Open

Warn when Powershell language mode is not full language #3326

zhili1208 opened this issue Aug 16, 2016 · 2 comments
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.Client Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time Type:DCR Design Change Request
Milestone

Comments

@zhili1208
Copy link
Contributor

#3312

In bug 3312, Since we don't have clear warning message for powershell language mode, we wasted a lot of time to investigate that issue.

In our current code, we only check execution policy, but language mode also will impact script running.
ConstrainedLanguage
Exposes a subset of the PowerShell language that limits itself to core PowerShell types, does not support method invocation (except on those types), and does not support property setters (except on those types).

FullLanguage
Commands that contain any Windows PowerShell language elements are allowed. This field is introduced in Windows PowerShell 2.0.

NoLanguage
Only commands that are using the System.Management.Automation.Runspaces functionality are allowed. This field is introduced in Windows PowerShell 2.0.

RestrictedLanguage
Commands that contain scripts that need to be evaluated are not allowed.

So if the language mode is not full language, the customer might can't run script. In this case, we should warn.

@rrelyea rrelyea added this to the 3.5 RTM milestone Aug 17, 2016
@rrelyea rrelyea added the Area:ErrorHandling warnings and errors/log messages & related error codes. label Aug 17, 2016
@rrelyea rrelyea added the Type:DCR Design Change Request label Aug 17, 2016
@rrelyea
Copy link
Contributor

rrelyea commented Aug 17, 2016

Sounds good.
Please address this in dev branch

@rrelyea rrelyea added Product:VS.Client Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels Aug 18, 2016
@rrelyea rrelyea modified the milestones: 3.6 Beta1, 3.5 RTM Aug 18, 2016
@rrelyea
Copy link
Contributor

rrelyea commented Aug 18, 2016

Let's not target 3.5-rtm, as time is short. Just 3.6 b1.

@rrelyea rrelyea modified the milestones: 3.6 Beta1, 3.6 Beta2 Sep 22, 2016
@rrelyea rrelyea modified the milestones: 3.6 RC2, 3.6 RC Oct 21, 2016
@rrelyea rrelyea modified the milestones: 4.0 RC2, 4.0 RC3 Nov 29, 2016
@rrelyea rrelyea modified the milestones: Future-1, 4.0 RC3 Jan 3, 2017
@rrelyea rrelyea modified the milestones: Future-1, Backlog Feb 22, 2019
@ghost ghost added the Status:Inactive Icebox issues not updated for a specific long time label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.Client Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

5 participants