Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly Binding Redirects Do Not Work as Expected in Project.json only #3372

Closed
Mike-E-angelo opened this issue Aug 25, 2016 · 2 comments
Closed
Assignees
Milestone

Comments

@Mike-E-angelo
Copy link

3.0 is super awesome and amazing. It is very impressive and vastly improves the user experience in Visual Studio reference management. However, the one (noticeable) feature that seems to have been overlooked is that of assembly binding redirects.

As an example, I recently had an update arrive for Moq 4.5.21.0 (from 4.5.16.0). The binding redirect looked like this in my unit testing App.config:

<dependentAssembly>
    <assemblyIdentity name="Moq" publicKeyToken="69f491c39445e920" culture="neutral" />
    <bindingRedirect oldVersion="0.0.0.0-4.5.16.0" newVersion="4.5.16.0" />
</dependentAssembly>

After installing the latest Moq I would expect it to look like this:

<dependentAssembly>
    <assemblyIdentity name="Moq" publicKeyToken="69f491c39445e920" culture="neutral" />
    <bindingRedirect oldVersion="0.0.0.0-4.5.21.0" newVersion="4.5.21.0" />
</dependentAssembly>

However, this did not occur, and I had to do it manually. In 2.0 this worked without intervention. It would be great to have this return in 3.0. Thank you for any consideration!

@rrelyea
Copy link
Contributor

rrelyea commented Aug 29, 2016

Let's discuss in tomorrow's meeting.

@rrelyea rrelyea changed the title Assembly Binding Redirects Do Not Work as Expected in 3.0 Assembly Binding Redirects Do Not Work as Expected in Project.json only Dec 13, 2016
@rrelyea rrelyea added this to the Future-2 milestone Dec 13, 2016
@nkolev92
Copy link
Member

nkolev92 commented Feb 2, 2018

Binding redirects is not a concept that's handled by NuGet in project.json and PackageReference worlds.
It's now handled by the VS project-system.

@nkolev92 nkolev92 closed this as completed Feb 2, 2018
@nkolev92 nkolev92 modified the milestones: Future-2, Backlog, 4.7 Feb 2, 2018
@rrelyea rrelyea added the Resolution:External This issue appears to be External to nuget label May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants