Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download/Restore operations should check the http cache before making http calls to all sources #3392

Closed
emgarten opened this issue Aug 30, 2016 · 2 comments
Labels
Area:HttpCaching http caching by all tools Functionality:Restore Icebox cleanup candidate Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Status:Inactive Icebox issues not updated for a specific long time Tenet:Performance Performance issues
Milestone

Comments

@emgarten
Copy link
Member

Download and restore operations should check the http cache before making http calls to all sources. In many cases the package already exists in the cache, but parallel calls are still made to all http sources. The source with the cached nupkg quickly wins but feeds but the tax of these extra calls are still incurred by both the client and servers.

Actual flow today

  1. Request a package id/version from all sources in parallel
  2. Each call individually checks the cache in parallel
  3. If the package is not found in the cache it goes online (always true for sources not containing the nupkg)

Expected flow

  1. Request a package id/version from the cache for all http sources in parallel (offline only)
  2. Check if any caches contained the nupkg
  3. Request a package id/version from all http sources in parallel (going online this time)
@rrelyea rrelyea added Tenet:Performance Performance issues Area:HttpCaching http caching by all tools labels Sep 1, 2016
@rrelyea rrelyea added this to the 3.6 Beta2 milestone Sep 1, 2016
@joelverhagen joelverhagen removed their assignment Nov 9, 2017
@emgarten emgarten modified the milestones: Future-1, Backlog Feb 14, 2018
@emgarten emgarten added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Feb 14, 2018
@nkolev92 nkolev92 changed the title Download/Restore operations should check the cache before making http calls Download/Restore operations should check the http cache before making http calls to all sources Jul 3, 2020
@nkolev92 nkolev92 added Pipeline:Backlog Priority:2 Issues for the current backlog. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Pipeline:Icebox Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Priority:2 Issues for the current backlog. labels Jul 3, 2020
@ghost ghost added the Status:Inactive Icebox issues not updated for a specific long time label Sep 1, 2022
@ghost
Copy link

ghost commented Nov 18, 2022

Due to lack of recent activity, this issue has been marked as a candidate for icebox cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will add a Triage:NeedsTriageDiscussion label and lead to a triaging process.
This process is part of the experimental Stale icebox issues cleanup we are currently trialing. Please share any feedback you might have in the linked issue.

@ghost
Copy link

ghost commented Dec 2, 2022

This issue will now be closed since it had been marked Icebox cleanup candidate, but received no further activity in the past 14 days.

@ghost ghost closed this as completed Dec 2, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:HttpCaching http caching by all tools Functionality:Restore Icebox cleanup candidate Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Status:Inactive Icebox issues not updated for a specific long time Tenet:Performance Performance issues
Projects
None yet
Development

No branches or pull requests

5 participants