Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Client no-op for legacy package reference #5444

Closed
nkolev92 opened this issue Jun 19, 2017 · 0 comments · Fixed by NuGet/NuGet.Client#1659
Closed

Cross-Client no-op for legacy package reference #5444

nkolev92 opened this issue Jun 19, 2017 · 0 comments · Fixed by NuGet/NuGet.Client#1659
Assignees
Labels
Functionality:Install The install command in VS/nuget.exe Functionality:Restore
Milestone

Comments

@nkolev92
Copy link
Member

nkolev92 commented Jun 19, 2017

The secondary target of this feature is to unify the restore behavior among all our clients.
One can restore with NuGet.exe, open VS, and then auto-restore no-ops. When that, the user can build use msbuild /t:restore and that would no-op as well.

At this point that's not the case.
The dg spec generated for msbuild/nuget.exe/dotnet.exe case is not the same as the one generated by VS. Some of those inconsistencies have been resolved, while others haven't.

Here's a table of the presumed behavior (meaning, as far as we know, there might be some crazy scenarios in which this breaks, and when encountered, we'll want to fix them.

Project Model NuGet.Exe & VS Client NuGet.exe & dotnet.exe NuGet.exe & MsBuild VS Client & dotnet.exe VS Client & MsBuild MsBuild & dotnet.exe
.NET Core - SDK based projects Consistent Consistent. Consistent. Consistent. Consistent. Consistent.
Legacy Package Reference projects Inconsistent. Consistent. Consistent. Inconsistent. Consistent. Inconsistent.
Project.Json Inconsistent Consistent. Consistent. Inconsistent. Inconsistent. Consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Install The install command in VS/nuget.exe Functionality:Restore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants