Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter /tools on only TFM and RID, so the settings XML can be put in /tools folder #6197

Closed
wli3 opened this issue Nov 20, 2017 · 9 comments
Closed
Assignees
Labels
Area:RestoreTool V1/V2 tool restore Functionality:Restore Type:DCR Design Change Request
Milestone

Comments

@wli3
Copy link

wli3 commented Nov 20, 2017

Additional requirement:

To support filter with sub folder
Given following folder structure,

├───tools                                                  
│   └───netcoreapp2.0                                      
│       └───any                                            
│           │   DotnetToolSettings.xml                     
│           │                                              
│           ├───tool1                                      
│           │       Newtonsoft.Json.dll                    
│           │       tool1.dll                              
│           │       tool1.json                             
│           │       tool1.pdb                              
│           │       tool1.runtimeconfig.json               
│           │                                              
│           └───tool2                                      
│                   Newtonsoft.Json.dll                    
│                   tool2.dll                              
│                   tool2.json                             
│                   tool2.pdb                              
│                   tool2.runtimeconfig.json               
│                                                          

Both

tools/netcoreapp2.0/any/tool1/tool1.dll
tools/netcoreapp2.0/any/tool1/tool1.runtimeconfig.json
...
and
tools/netcoreapp2.0/any/tool2/tool2.dll
tools/netcoreapp2.0/any/tool2/tool2.runtimeconfig.json
...

Should be in asset.json-target-tools session.

@wli3
Copy link
Author

wli3 commented Nov 20, 2017

CLI ask for tools

@wli3 wli3 changed the title [tools CLI ask] Filter /tools on only TFM and RID, so the metadata XML can be put in /tools folder Filter /tools on only TFM and RID, so the metadata XML can be put in /tools folder Nov 20, 2017
@wli3 wli3 mentioned this issue Nov 20, 2017
4 tasks
@emgarten
Copy link
Member

@wli3 can you can some extra template paths to get this started? Will this need support for the runtimes/{rid}/native/ equivalent, or just runtimes/{rid}/lib/{tfm}

@wli3
Copy link
Author

wli3 commented Nov 20, 2017

can you can some extra template paths to get this started?

Sorry, could you add more detail of this question? Do you mean if I can get it started without blocking? Today, as in dotnet/cli#8035 without nuget filter, I am downloading everything

@wli3
Copy link
Author

wli3 commented Nov 20, 2017

Will this need support for the runtimes/{rid}/native/ equivalent, or just runtimes/{rid}/lib/{tfm}

Yes, we do need support for native. A folder named native is the same convention as in /lib folder right?

In the end, we need a place to store native tools, and NuGet can filter by TFM(including native) and RID, however, we hope the folder structure to be close to existing NuGet conversion, or what NuGet think is the best.

@emgarten
Copy link
Member

Native is similar, but there is no TFM.

@PatoBeltran PatoBeltran added the Type:DCR Design Change Request label Nov 20, 2017
@rrelyea rrelyea added this to the Backlog milestone Nov 22, 2017
@rrelyea rrelyea added the Priority:1 High priority issues that must be resolved in the current sprint. label Nov 22, 2017
@nkolev92 nkolev92 self-assigned this Dec 4, 2017
@nkolev92 nkolev92 added Area:RestoreTool V1/V2 tool restore and removed Priority:1 High priority issues that must be resolved in the current sprint. labels Dec 4, 2017
@wli3
Copy link
Author

wli3 commented Dec 6, 2017

We decide off line. The folder structure should be

tools/{TFM}/{RID}/mytool.dll

For portable, it should be
tools/{TFM}/any/mytool.dll

https://github.com/dotnet/cli/issues/8133

@wli3 wli3 changed the title Filter /tools on only TFM and RID, so the metadata XML can be put in /tools folder Filter /tools on only TFM and RID, so the settings XML can be put in /tools folder Dec 7, 2017
@wli3
Copy link
Author

wli3 commented Dec 7, 2017

FYI to unify the term "metadata xml" should be called "settings xml" file

@wli3
Copy link
Author

wli3 commented Jan 11, 2018

Added the subfolder support we talked about today

@nkolev92 nkolev92 modified the milestones: 4.6 - Dec26-Jan13, 4.7 Jan 11, 2018
@nkolev92
Copy link
Member

Closed in NuGet/NuGet.Client#1900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:RestoreTool V1/V2 tool restore Functionality:Restore Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

5 participants