Stop using CPS JTF #4288
Merged
Stop using CPS JTF #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
approved these changes
Sep 29, 2021
erdembayar
approved these changes
Sep 29, 2021
nkolev92
approved these changes
Sep 29, 2021
| @@ -69,13 +64,6 @@ public sealed class NuGetProjectFactory | |||
|
|
|||
| await _threadingService.JoinableTaskFactory.SwitchToMainThreadAsync(); | |||
|
|
|||
| if (vsProjectAdapter.VsHierarchy != null && | |||
There was a problem hiding this comment.
This is very satisfying! :)
It registers on every damn initialization UI delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#8317
Fixes: NuGet/Home#8414
Regression? no
Description
Remove all references to
IProjectServiceAccessorandNuGetUIThreadHelper.SetJoinableTaskFactoryFromService.Using
IProjectServiceAccessorwas the reason that NuGet's options screen didn't work in a minimal VS install. The options window caused NuGetPackage to be loaded, and our package load initializes our MEF objects, and one (or more) of the MEF objects tried to useIProjectServiceAccessor, which has no exports since CPS isn't installed without any workloads installed. By removing the need to get CPS's JTF, we no longer have dependencies on unavailable components when loading the options window.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation