Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuget pack does not include the PackageIcon #8610

Closed
0xced opened this issue Sep 19, 2019 · 2 comments
Closed

nuget pack does not include the PackageIcon #8610

0xced opened this issue Sep 19, 2019 · 2 comments
Labels
Functionality:Pack Resolution:Duplicate This issue appears to be a Duplicate of another issue Type:Bug
Milestone

Comments

@0xced
Copy link

0xced commented Sep 19, 2019

Details about Problem

NuGet product used: NuGet.exe

NuGet version: 5.3.0.6192

OS version: Microsoft Windows 10 Enterprise 10.0.14393

Worked before? Not applicable, this is new feature of NuGet 5.3

Detailed repro steps so we can see the same problem

  1. Clone https://github.com/NuGet/Samples/
  2. Run dotnet build PackageIconExample\PackageIconExample.csproj
  3. Run nuget pack PackageIconExample\PackageIconExample.csproj

The nupkg produced by the dotnet build command includes the icon.png.
The nupkg produced by the nuget pack command does not include the icon.png file.

I'd like to have it working with the nuget command instead of the dotnet command because I am building on TeamCity and installing several versions of the NuGet.exe tool is easy and also because I don't want to install preview or release candidate versions of .NET Core on the TeamCity build agent.

Am I missing an argument when running the nuget command? Is this a bug?

Verbose Logs

nuget pack PackageIconExample\PackageIconExample.csproj -Verbosity detailed
NuGet Version: 5.3.0.6192
Attempting to build package from 'PackageIconExample.csproj'.
MSBuild auto-detection: using msbuild version '16.2.37902.0' from 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\bin'. Use option -MSBuildVersion to force nuget to use a specific version of MSBuild.
Packing files from 'c:\Projects\GitHub\NuGet.Samples\PackageIconExample\bin\Debug\netstandard2.0'.
Add file 'c:\Projects\GitHub\NuGet.Samples\PackageIconExample\bin\Debug\netstandard2.0\PackageIconExample.dll' to package as 'lib\netstandard2.0\PackageIconExample.dll'
WARNING: NU5115: Description was not specified. Using 'Description'.

Id: PackageIconExample
Version: 1.0.2
Authors: PackageIconExample
Description: Description
Dependencies:

Added file '[Content_Types].xml'.
Added file '_rels/.rels'.
Added file 'lib/netstandard2.0/PackageIconExample.dll'.
Added file 'package/services/metadata/core-properties/253485c7be254c2eb4546d4b6dd61b19.psmdcp'.
Added file 'PackageIconExample.nuspec'.

Successfully created package 'c:\Projects\GitHub\NuGet.Samples\PackageIconExample.1.0.2.nupkg'.
WARNING: NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
- Add a dependency group for .NETStandard2.0 to the nuspec
@zkat zkat added this to the Backlog milestone Sep 19, 2019
@zkat zkat added the Resolution:Duplicate This issue appears to be a Duplicate of another issue label Sep 19, 2019
@zkat
Copy link
Contributor

zkat commented Sep 19, 2019

Closing as a duplicate of #4491. Thanks @nkolev92 for calling this out.

@zkat zkat closed this as completed Sep 19, 2019
@0xced
Copy link
Author

0xced commented Sep 20, 2019

Thanks for the quick reply. I think #7778 should really be prioritized as it looks like many people were mislead thinking that nuget pack would work with csproj files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Pack Resolution:Duplicate This issue appears to be a Duplicate of another issue Type:Bug
Projects
None yet
Development

No branches or pull requests

2 participants