Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Make restore types that are project.json-specific obsolete #9149

Closed
nkolev92 opened this issue Feb 7, 2020 · 0 comments · Fixed by NuGet/NuGet.Client#4243
Closed

[5.x] Make restore types that are project.json-specific obsolete #9149

nkolev92 opened this issue Feb 7, 2020 · 0 comments · Fixed by NuGet/NuGet.Client#4243
Assignees
@nkolev92
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Style:PackageReference Type:Engineering product/infrastructure work/not a customer bug/feature/DCR
Milestone
Sprint 2021-09

Comments

@nkolev92
Copy link
Member

nkolev92 commented Feb 7, 2020

For example https://github.com/NuGet/NuGet.Client/blob/7bac015acc5b7e0161a058c8febc98abe2386d51/src/NuGet.Core/NuGet.LibraryModel/LibraryDependency.cs#L16 is not very useful anymore.

Same applies to a lot of types throughout restore.
This was referenced Feb 7, 2020
Merged
Merged
@aortiz-msft aortiz-msft added the Priority:2 Issues for the current backlog. label Feb 24, 2020
@aortiz-msft aortiz-msft changed the title Obsolete restore types that project.json specific Make restore types that are project.json-specific obsolete Feb 24, 2020
@aortiz-msft aortiz-msft changed the title Make restore types that are project.json-specific obsolete [5.x] Make restore types that are project.json-specific obsolete Feb 24, 2020
@nkolev92 nkolev92 added Functionality:SDK The NuGet client packages published to nuget.org and removed NuGet API labels Apr 24, 2020
@nkolev92 nkolev92 added the Category:Quality Week Issues that should be considered for quality week label Jul 24, 2020
@nkolev92 nkolev92 self-assigned this Jul 24, 2020
@nkolev92 nkolev92 added this to the Sprint 2021-07 milestone Jul 12, 2021
@nkolev92 nkolev92 mentioned this issue Sep 2, 2021
Merged
8 tasks
@kartheekp-ms kartheekp-ms added the Type:Engineering product/infrastructure work/not a customer bug/feature/DCR label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Style:PackageReference Type:Engineering product/infrastructure work/not a customer bug/feature/DCR
Projects
None yet
Milestone
Sprint 2021-09
4 participants
@nkolev92 @heng-liu @kartheekp-ms @aortiz-msft