Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pooled StringBuilder #5665

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Use pooled StringBuilder #5665

merged 1 commit into from
Mar 4, 2024

Conversation

Erarndt
Copy link
Contributor

@Erarndt Erarndt commented Mar 1, 2024 •
edited by jeffkl
Loading

Bug

Fixes: NuGet/Home#13285

Regression? Last working version:

Description

Use StringBuilderPool in NuGet.Frameworks for hot code paths to reduce allocations.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception - Existing coverage
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@Erarndt Erarndt requested a review from a team as a code owner March 1, 2024 20:01
@jeffkl jeffkl self-assigned this Mar 1, 2024
@jeffkl jeffkl added Approved for CI Community PRs created by someone not in the NuGet team labels Mar 1, 2024
@jeffkl jeffkl merged commit 34f9e1a into NuGet:dev Mar 4, 2024
16 checks passed
@Erarndt Erarndt deleted the dev-erarndt-pooledStringBuilder branch March 4, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnie-msft donnie-msft donnie-msft approved these changes

@jeffkl jeffkl jeffkl approved these changes

Assignees

@jeffkl jeffkl

Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the StringBuilderPool rather than allocating a new StringBuilder
3 participants
@Erarndt @jeffkl @donnie-msft