Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: SDK packages should have explicit Framework metadata #9081

Open
jzabroski opened this issue Mar 30, 2022 · 1 comment
Open

[Feature]: SDK packages should have explicit Framework metadata #9081

jzabroski opened this issue Mar 30, 2022 · 1 comment
Assignees
Labels
feature-request Customer feature request
Milestone

Comments

@jzabroski
Copy link

Related Problem

#9015

The Elevator Pitch

I just uninstalled VS2019 and installed VS2022, and when I went to run a csproj with <Project Sdk="Microsoft.Build.NoTargets/3.3.0">, I get the following error message insisting that I install the .NET 4.8 Developer Pack.

I think this is possibly two issues:

  1. SDKs should have explicit bootstrap requirements, and those bootstrap requirements should get serialized into nuget package metadata, so that it is viewable in the gallery. https://www.nuget.org/packages/Microsoft.Build.NoTargets
  2. The gallery should do a better job displaying framework info for this scenario. See the related problem discussion in [Feature]: Tool Packages should display differently than library packages  #9015

Additional Context and Details

If I go to https://www.nuget.org/packages/Microsoft.Build.NoTargets I see the following

image

This probably also owes an issue with another team at Microsoft, possibly the MSBuild tea or another team, but I am not well versed in the political structures at Microsoft.

@jzabroski jzabroski added the feature-request Customer feature request label Mar 30, 2022
@jzabroski jzabroski changed the title [Feature]: SDK packages have explicit metadata [Feature]: SDK packages should have explicit metadata Mar 30, 2022
@jzabroski jzabroski changed the title [Feature]: SDK packages should have explicit metadata [Feature]: SDK packages should have explicit Framework metadata Mar 30, 2022
@joelverhagen
Copy link
Member

This package has the following package type:

    <packageTypes>
      <packageType name="MSBuildSdk" />
    </packageTypes>

We could consider hiding the Frameworks tab in this specific case, or if the package type is not in some short allow list.

Currently, it's being treated like a normal dependency package by the Frameworks tab but it has no recognized assets.

@keylime-unicorn keylime-unicorn added this to the Backlog milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Customer feature request
Projects
None yet
Development

No branches or pull requests

5 participants