Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable W ^ E in V8 for node.js build #40

Open
No9 opened this issue May 6, 2018 · 0 comments
Open

Enable W ^ E in V8 for node.js build #40

No9 opened this issue May 6, 2018 · 0 comments

Comments

@No9
Copy link

No9 commented May 6, 2018

As mentioned on twitter https://twitter.com/EdSchouten/status/993144257438502912
cloudabi executables require W^E memory

V8 runtime enabled this by default in this commit v8/v8@bf19e60
However there seems to be a conflict with WASM so the feature has been put behind a flag for now
https://bugs.chromium.org/p/v8/issues/detail?id=7272
The flag is --write-protect-code-memory

I would have thought patching this line https://github.com/nodejs/node/blob/82e475dc75751df08d80bd6e25926bd25c1794f2/deps/v8/src/flag-definitions.h#L675 to true should be enough to get this up and running but any thoughts appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant