Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to remove deprecated use of ODM2 module hierarchy #168

Closed
emiliom opened this issue Apr 20, 2019 · 2 comments
Closed

Update tests to remove deprecated use of ODM2 module hierarchy #168

emiliom opened this issue Apr 20, 2019 · 2 comments
Milestone
v0.7.2 release

Comments

@emiliom
Copy link
Member

emiliom commented Apr 20, 2019

Doing this would make the output of the tests (eg, "warnings summary" on TravisCI, such as this one) much less cluttered and easier to digest.

Plus, we have to move away from that deprecated module hierarchy anyway. Better sooner than later.

Example of current warning output:

/tmp/tests/test_SessionFactory.py:3: FutureWarning: 
The module odm2api.ODM2.models will be deprecated. 
Please use odm2api.models instead.
  from odm2api.ODM2.models import CVElevationDatum, setSchema
@emiliom emiliom added this to the v0.7.2 release milestone Apr 20, 2019
@emiliom
Copy link
Member Author

emiliom commented Apr 20, 2019

PR #170 started to address this. More changes are needed

@emiliom emiliom mentioned this issue Apr 21, 2019
Merged
@emiliom
Copy link
Member Author

emiliom commented Apr 21, 2019

Completed by PR #171

@emiliom emiliom closed this as completed Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.2 release
Development

No branches or pull requests
1 participant
@emiliom