Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe model description missing and model scubscription QoL #152

Open
ahilloffis opened this issue Jan 13, 2025 · 0 comments
Open

Subscribe model description missing and model scubscription QoL #152

ahilloffis opened this issue Jan 13, 2025 · 0 comments
Assignees

Comments

@ahilloffis
Copy link

Subscribing to a model change is a nice feature but it's missing documentation and the usage is a little counterintuitive:

self.context.subscribe_model(self, type(model))

Instead of type(model) as a parameter, I would expect model or MyClass.

Also, instead of just subscribing to the model and handling the change in the def on_change_model(self, model) method of the class, passing a method, like in other context subscriptions, would be a nice feature. If needed, I will create another issue for this topic.

@rcschrg rcschrg self-assigned this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants