Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isStudyLoading bool from Viewer component #1283

Closed
dannyrb opened this issue Dec 11, 2019 · 3 comments
Closed

Remove isStudyLoading bool from Viewer component #1283

dannyrb opened this issue Dec 11, 2019 · 3 comments
Labels
Up For Grabs

Comments

@dannyrb
Copy link
Member

dannyrb commented Dec 11, 2019 •
edited
Loading

RE: #954

The DICOMSR logic keys off a property in the <Viewer> component named isStudyLoading. It's possible, and cleaner, to remove this loading bool.

See: https://github.com/OHIF/Viewers/pull/954/files/c29a4f67114f1e9ff9dfffa10dd21cb2dc606d76#diff-acf605965e02491d822a993ef89426ab
@stale
Copy link

stale bot commented Jan 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale 🥖 label Jan 1, 2020
@dannyrb
Copy link
Member Author

dannyrb commented Jan 2, 2020

👢 💨 🤖

@stale stale bot removed the Stale 🥖 label Jan 2, 2020
@stale
Copy link

stale bot commented Jan 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale 🥖 label Jan 24, 2020
@dannyrb dannyrb closed this as completed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Up For Grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dannyrb