Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DICOM SR measurement schema and versioning hazards #1284

Closed
dannyrb opened this issue Dec 11, 2019 · 0 comments
Closed

DICOM SR measurement schema and versioning hazards #1284

dannyrb opened this issue Dec 11, 2019 · 0 comments

Comments

@dannyrb
Copy link
Member

dannyrb commented Dec 11, 2019

RE: https://github.com/OHIF/Viewers/pull/954/files
RE: #954 (comment)

Do we do anything to check that data in the SR maps to something our application can display? For example, how should we handle:

There is Length data in the structured report, but...

  • No Length cornerstone-tool is "added" and "enabled"
  • OR no Length vtk.js widget
  • OR cornerstone-tool's Length tool expects a different tool state "shape"
    • We modify it at a later date, or the user has a custom Length tool

There are a lot of pitfalls we need to carefully navigate. What we can reasonably support, and how we can fail gracefully is something we should discuss.

CC: @JamesAPetts

@sedghi sedghi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants