Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhotometricInterpretation ignored #3121

Closed
edotassi opened this issue Jan 17, 2023 · 7 comments
Closed

PhotometricInterpretation ignored #3121

edotassi opened this issue Jan 17, 2023 · 7 comments
Labels
Awaiting Reproduction Can we reproduce the reported bug?

Comments

@edotassi
Copy link

edotassi commented Jan 17, 2023

Hi!

Describe the Bug

Viewer ignore PhotometricInterpretation tag value

Steps to Reproduce:

Open a studio with PhotometricInterpretation valued at MONOCHROME1

The current behavior

Screenshot 2023-01-17 alle 14 59 17

The expected behavior

If I click on "invert" it works fine:

Screenshot 2023-01-17 alle 14 59 21

Thanks!

@edotassi edotassi added Awaiting Reproduction Can we reproduce the reported bug? Community: Report 🐛 labels Jan 17, 2023
@sedghi
Copy link
Member

sedghi commented Jan 18, 2023

can you drag and drop here and post the results
https://www.cornerstonejs.org/live-examples/local.html

@edotassi
Copy link
Author

edotassi commented Jan 18, 2023

Hi @sedghi , this is the result:

Screenshot 2023-01-18 alle 22 07 47

meanwhile I applied a temporary patch to our version, with this patch I can make the software work properly (at the moment it is used in production by our customers):

Screenshot 2023-01-18 alle 22 09 14

Screenshot 2023-01-18 alle 22 09 36

now it works properly:
Screenshot 2023-01-18 alle 22 08 12

thanks!

@sedghi
Copy link
Member

sedghi commented Jan 18, 2023

So this should get fixed on the cs3d side(since rendering engine is cs3d).

By the way what are you using for screenshots, they look awesome!

@edotassi
Copy link
Author

@sedghi so is it a bug? or are our dicom files corrupt?

for screenshots I use the key combination SHIFT+CMD+4 and then SPACE on mac osx, did you mean this?

@sedghi
Copy link
Member

sedghi commented Jan 18, 2023

Can you share the data?

@edotassi
Copy link
Author

@sedghi sure!

dicom_test.zip

@sedghi
Copy link
Member

sedghi commented Oct 13, 2023

Please review the latest code in the master branch. I am confident that this issue has been resolved. If it persists, kindly reopen the issue with updated details.

Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing

@sedghi sedghi closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Reproduction Can we reproduce the reported bug?
Projects
None yet
Development

No branches or pull requests

2 participants