Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Default SOPClassHandler / Display Set for unsupported SOPClassUID #3362

Closed
igoroctaviano opened this issue May 3, 2023 · 5 comments
Assignees
Labels
Feature Request IDC:priority Items that the Imaging Data Commons wants to help sponsor

Comments

@igoroctaviano
Copy link
Contributor

igoroctaviano commented May 3, 2023

Request

Display a thumbnail (display set) in the gallery even when the SOPClassUID is not supported.

Maybe we should display a UI icon or indication that the sop class is not supported?

This allows the user to know that the data is coming back correctly from the server but it's not supported.

Context

Before the merge of RTStruct support, IDC identified that for this study this the RT series was not showing up (probably because OHIF didn't have any default sop handler for RTStructs back then)

@igoroctaviano igoroctaviano added Community: Request ✋ IDC:candidate Possible feature requests for discussion, and if we agree, they can be relabeled IDC:priority labels May 3, 2023
@igoroctaviano igoroctaviano changed the title v3: Default SOPClassHandler / Display Set for unsupported SOPClassUID [Feature Request] v3: Default SOPClassHandler / Display Set for unsupported SOPClassUID Jul 7, 2023
@sedghi
Copy link
Member

sedghi commented Jul 20, 2023

This and #3411 might be related

@igoroctaviano igoroctaviano changed the title [Feature Request] v3: Default SOPClassHandler / Display Set for unsupported SOPClassUID [Feature Request] Default SOPClassHandler / Display Set for unsupported SOPClassUID Aug 2, 2023
@rodrigobasilio2022 rodrigobasilio2022 self-assigned this Aug 8, 2023
@jbocce jbocce removed their assignment Aug 9, 2023
@igoroctaviano igoroctaviano removed the IDC:candidate Possible feature requests for discussion, and if we agree, they can be relabeled IDC:priority label Aug 10, 2023
@igoroctaviano igoroctaviano added the IDC:candidate Possible feature requests for discussion, and if we agree, they can be relabeled IDC:priority label Aug 10, 2023
@james-hanks
Copy link

@rodrigobasilio2022 reach out to @sedghi for questions

@fedorov fedorov added IDC:priority Items that the Imaging Data Commons wants to help sponsor and removed IDC:candidate Possible feature requests for discussion, and if we agree, they can be relabeled IDC:priority labels Aug 11, 2023
@fedorov
Copy link
Member

fedorov commented Aug 11, 2023

@rodrigobasilio2022 you can use the query below to get a sample of distinct values of SOPClassUID and a sample SOPInstanceUID value for each class. You can then point your viewer to those UIDs.

SELECT
  SOPClassUID,
  ANY_VALUE(Modality),
  ANY_VALUE(StudyInstanceUID)
FROM
  `bigquery-public-data.idc_current.dicom_all`
GROUP BY
  SOPClassUID
SOPClassUID	           Modality	Sample SOPInstanceUID
1.2.840.10008.5.1.4.1.1.3.1	US	1.3.6.1.4.1.14519.5.2.1.1188.2803.137646705698249807710568964202
1.2.840.10008.5.1.4.1.1.88.22	SR	1.3.6.1.4.1.32722.99.99.195760763849544751837486809570181736382
1.2.840.10008.5.1.4.1.1.6.1	US	1.3.6.1.4.1.14519.5.2.1.1600.1201.209914590159324149959370228847
1.2.840.10008.5.1.4.1.1.88.33	SR	1.3.6.1.4.1.14519.5.2.1.7695.1700.309371888160898448824018772961
1.2.840.10008.5.1.4.1.1.20	NM	1.3.6.1.4.1.14519.5.2.1.99.1071.18502340383544479609937077864159
1.2.840.10008.5.1.4.1.1.88.67	SR	1.3.6.1.4.1.14519.5.2.1.99.1071.68020620852515470553433478627305
1.2.840.10008.5.1.4.1.1.88.34	SR	1.2.840.113654.2.55.113024534186782261514996538397170209196
1.2.840.10008.5.1.4.1.1.4	MR	1.3.6.1.4.1.14519.5.2.1.3320.3273.119041692754915148586879613084
1.2.840.10008.5.1.4.1.1.88.71	SR	1.3.6.1.4.1.5962.1.1.0.0.0.1563690660.7173.1351
1.2.840.10008.5.1.4.1.1.481.2	RTDOSE	1.3.6.1.4.1.14519.5.2.1.308250233404174127024116250321380712318
1.2.840.10008.5.1.4.1.1.1.2.1	MG	1.3.6.1.4.1.14519.5.2.1.2135.6389.325502166460246085196439020192
1.2.840.10008.5.1.4.1.1.13.1.3	MG	1.2.826.0.1.3680043.8.498.89881086537096230017864154427695982670
1.2.840.10008.5.1.4.1.1.7	XC	1.3.6.1.4.1.5962.1.2.0.1672334394.26545
1.2.840.10008.5.1.4.1.1.77.1.6	SM	2.25.250350883741587666065385578813454094570
1.2.840.10008.5.1.4.1.1.67	RWV	1.3.6.1.4.1.14519.5.2.1.111778973144870709834087260276851352536
1.2.840.10008.5.1.4.1.1.88.59	KO	1.3.6.1.4.1.14519.5.2.1.2103.7010.237254940005841719629537222159
1.2.840.10008.5.1.4.1.1.66.4	SEG	1.3.6.1.4.1.9328.50.2.154317
1.2.840.10008.5.1.4.1.1.11.8	PR	2.25.253443077977640338251305809014416841249
1.2.840.10008.5.1.4.1.1.1.2	MG	1.3.6.1.4.1.14519.5.2.1.1239.1759.244441635524602481133579861840
1.2.840.10008.5.1.4.1.1.66.1	REG	1.3.6.1.4.1.14519.5.2.1.122805535915539618236860659468790107523
1.2.840.10008.5.1.4.1.1.481.3	RTSTRUCT	1.3.6.1.4.1.14519.5.2.1.290357524196812386389556627309084749311
1.2.840.10008.5.1.4.1.1.1.1	DX	1.3.6.1.4.1.14519.5.2.1.99.1071.15948488190457108088404148351824
1.2.840.10008.5.1.4.1.1.11.1	PR	1.3.6.1.4.1.9328.50.1.87211270270881058665839423712882980237
1.2.840.10008.5.1.4.1.1.66	MR	2.25.9357376018826927515236104299376823405
1.2.840.10008.5.1.4.1.1.1	CR	1.3.6.1.4.1.14519.5.2.1.99.1071.32359744952175639724021277376428
1.2.840.10008.5.1.4.1.1.128	PT	1.3.6.1.4.1.14519.5.2.1.3320.3273.106006226303617959547675899577
1.2.840.10008.5.1.4.1.1.481.5	RTPLAN	1.3.6.1.4.1.14519.5.2.1.340031522181513869336683393500230688871
1.2.840.10008.5.1.4.1.1.2	CT	1.3.6.1.4.1.14519.5.2.1.5826.1402.124013116882377217225761523253
1.2.840.10008.5.1.4.1.1.1.1.1	DX	1.3.6.1.4.1.14519.5.2.1.1600.1202.317950861285552387576089292503

You should look into this tutorial to get started with querying IDC data using BigQuery SQL, if you want to run the query above or do similar queries: https://github.com/ImagingDataCommons/IDC-Tutorials/blob/master/notebooks/getting_started/part2_searching_basics.ipynb. Let me know if you have any questions.

@rodrigobasilio2022
Copy link
Collaborator

This PR was approved and in the queue for merge

@igoroctaviano
Copy link
Contributor Author

Done! #3601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
None yet
Development

No branches or pull requests

6 participants