Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Image Wrong Size in the viewport #3520

Closed
francomotta opened this issue Jul 5, 2023 · 6 comments
Closed

[Bug] Image Wrong Size in the viewport #3520

francomotta opened this issue Jul 5, 2023 · 6 comments
Assignees
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)

Comments

@francomotta
Copy link

Describe the Bug

When loading a study, the images are the wrong size in the viewport.

Steps to Reproduce

Select the TCGA-QQ-A8VH study, select the 1x3 layout. Notice that the first viewport image displays the image at the wrong size (big). If you hit the "=" key, it makes the image the correct size. The same problem occurs if you double-click the image to get it to 1x1 format.

The right thing would be to put an option after opening the images to adjust the size in the viewport.
Wrong size-2023-07-05 140722

The current behavior

Note that the first image is the wrong size.
Wrong size-2023-07-05 140722

The expected behavior

The right thing would be to put an option after opening the images to adjust the size in the viewport.
Correct size-2023-07-05 140722

OS

Windows 11

Node version

20.3.0

Browser

Chrome

@francomotta francomotta added the Awaiting Reproduction Can we reproduce the reported bug? label Jul 5, 2023
@jbocce jbocce added Bugs Bug reported, reproducible, and verified. and removed Awaiting Reproduction Can we reproduce the reported bug? labels Jul 7, 2023
@francomotta
Copy link
Author

@jbocce , how are you?

Even with that tip, the error continues. Occurs most frequently in the 1x3 format with MR.

@sedghi
Copy link
Member

sedghi commented Jul 20, 2023

Bill recently merged a fix for resize, maybe this is fixed now?

@sedghi
Copy link
Member

sedghi commented Oct 3, 2023

So this is a tricky one, since we moved away from our previous setup where we re-created the viewports, and now the viewport (html div) would MOVE to the new location (for performance gain) and since there is no extra render, the camera is not changed. I don't think this is a sever problem, but if you think it is let us know

@sedghi
Copy link
Member

sedghi commented Oct 18, 2023

So in tmtv mode for instance, if we move from one stage to another, the old viewport (image) sized is preserved as of the new way of assiging Ids to viewports and not index (React just moves the element and canvas to the next stage, which is really super performant, but comes at the cost that we get wrong size, and we should trigger a resize maybe after the layout change

CleanShot 2023-10-18 at 10 43 06

@sedghi sedghi added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) and removed Bugs Bug reported, reproducible, and verified. labels Feb 21, 2024
@Srikanthkurva
Copy link

Hi
I have successfully running this "https://github.com/OHIF/Viewers?tab=readme-ov-file". I have one DCOM folder Images. Now I have replace with my DCOM images. How to replace my DCOM images. I have Tried. Please Could you help me.
OHIF1

@sedghi
Copy link
Member

sedghi commented May 1, 2024

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.

@sedghi sedghi closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)
Projects
None yet
Development

No branches or pull requests

4 participants