-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(memory leak): array buffer was sticking around in volume viewports #3611
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3611 +/- ##
=======================================
Coverage 42.58% 42.58%
=======================================
Files 80 80
Lines 1463 1463
Branches 340 340
=======================================
Hits 623 623
Misses 675 675
Partials 165 165 Continue to review full report in Codecov by Sentry.
|
"@cornerstonejs/adapters": "^1.10.3", | ||
"@cornerstonejs/core": "^1.10.3", | ||
"@cornerstonejs/tools": "^1.10.3", | ||
"@cornerstonejs/adapters": "^1.11.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get the prefetch fixes in as well? That issue is also related to how the memory gets handled, and I'd like to see the two of them combined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean? in this PR? (I have not reviewed/tested that again)
Context
purge cache was not freeing up memory since the deactivate texture calls had an exception which caused the scalardata to hang around.
Also previously we were terminating the web workers when going back to the worklist since that prob helped with the memory leak but has performance issues for invoking them again, that step is now removed, so you should expect perf gains going back and forth between studies and worklist
CC: @chafey (re web worker)
Changes & Results
re-order the destroy calls
Testing
after

Before

Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment