Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Segmentation mode mouse cursor dissapears #3824

Closed
efimfurman opened this issue Nov 29, 2023 · 8 comments · Fixed by cornerstonejs/cornerstone3D#961
Closed

[Bug] Segmentation mode mouse cursor dissapears #3824

efimfurman opened this issue Nov 29, 2023 · 8 comments · Fixed by cornerstonejs/cornerstone3D#961
Assignees
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)

Comments

@efimfurman
Copy link

efimfurman commented Nov 29, 2023

Describe the Bug

In segmentation mode, using a rectangle brush, I add a rectangle and then can cause the mouse cursor to disappear which makes it very difficult to know where to draw another rectangle.

Steps to Reproduce

Updates steps from the OHIF office meeting:
Happens with several tools, clicking in segmentation mode on edge of shape. Also seems to happen with a second segment getting added. Issue is that tools allow both click/move/click to create, and drag to create.

Here's a video demonstration
https://www.loom.com/share/6e9094563a184af6ba4b2ec97d464fec?sid=9e503436-3ead-4d06-b0a8-ca9b967a7d60

The current behavior

Mosue can disappear which makes it very difficult to know where to draw.

The expected behavior

The Mouse pointer should always be visible.

OS

MacOS Chrome

Node version

18.16.1

Browser

Chrome

@efimfurman efimfurman added the Awaiting Reproduction Can we reproduce the reported bug? label Nov 29, 2023
@sedghi
Copy link
Member

sedghi commented Nov 30, 2023

CleanShot 2023-11-30 at 15 29 45

@efimfurman
Copy link
Author

@sedghi Apologies, I accidentally deleted the recording. Here's a new one: https://www.loom.com/share/6e9094563a184af6ba4b2ec97d464fec?sid=9e503436-3ead-4d06-b0a8-ca9b967a7d60

@sedghi
Copy link
Member

sedghi commented Dec 13, 2023

Hmmm, so seems like if you really try to break it it will break :D

@efimfurman
Copy link
Author

@sedghi It happens to me frequently during normal use. I have to actually be very careful not to click multiple times. When I normally draw more than one box, I seem to lose the curser, so I disagree - for me, it happens during normal use. The above is a forceful way to recreate the issue on demand.

@sedghi
Copy link
Member

sedghi commented Dec 13, 2023

I see, I will look

@sedghi sedghi added Bugs Bug reported, reproducible, and verified. and removed Awaiting Reproduction Can we reproduce the reported bug? labels Dec 13, 2023
@efimfurman
Copy link
Author

@sedghi Per today's meeting, here are the updated details:

Happens with several tools, clicking in segmentation mode on edge of shape. Also seems to happen with a second segment getting added. Issue is that tools allow both click/move/click to create, and drag to create.

So, no need to click multiple times, nor is there a need to use MPR mode for this, the steps above are enough...

@sedghi
Copy link
Member

sedghi commented Jan 8, 2024

OHIF should get updated with latest cs3d version for proper fix

@sedghi sedghi added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) and removed Bugs Bug reported, reproducible, and verified. labels Jan 9, 2024
@sedghi
Copy link
Member

sedghi commented May 1, 2024

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.

@sedghi sedghi closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)
Projects
None yet
2 participants