fix(dicom-video): Update get direct func for dicom json to use url if present and fix config argument #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
igoroctaviano
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4017 +/- ##
=======================================
Coverage 44.37% 44.37%
=======================================
Files 80 80
Lines 1334 1334
Branches 327 327
=======================================
Hits 592 592
Misses 589 589
Partials 153 153 Continue to review full report in Codecov by Sentry.
|
Passing run #3803 ↗︎
Details:
Review all test suite changes for PR #4017 ↗︎ |
|||||||||||||||
wayfarer3130
reviewed
Apr 9, 2024
platform/ui/src/components/HeaderPatientInfo/HeaderPatientInfo.tsx
Outdated
Show resolved
Hide resolved
|
Can you rebase and check the failing tests? |
sedghi
approved these changes
Apr 10, 2024
thanh-nguyen-dang
pushed a commit
to uc-cdis/Viewers
that referenced
this pull request
May 1, 2024
… present and fix config argument (OHIF#4017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order to use dicom json datastore with video es dicom files, the URL from dicom json has to be passed to the direct URL method so it will be used as the video src
Changes & Results
Testing
Load a ES study using dicom json
Checklist
N/A
PR
semantic-release format and guidelines.
Code
N/A
Public Documentation Updates
N/A
additions or removals.
Tested Environment