fix(general): enhancements and bug fixes #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev canceled.
|
✅ Deploy Preview for ohif-platform-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4018 +/- ##
=======================================
Coverage 44.37% 44.37%
=======================================
Files 80 80
Lines 1334 1334
Branches 327 327
=======================================
Hits 592 592
Misses 589 589
Partials 153 153
Continue to review full report in Codecov by Sentry.
|
Passing run #3801 ↗︎
Details:
Review all test suite changes for PR #4018 ↗︎ |
|||||||||||||||
sedghi
reviewed
Apr 8, 2024
extensions/measurement-tracking/src/contexts/TrackedMeasurementsContext/promptBeginTracking.js
Outdated
Show resolved
Hide resolved
sedghi
reviewed
Apr 8, 2024
extensions/measurement-tracking/src/contexts/TrackedMeasurementsContext/promptTrackNewStudy.js
Outdated
Show resolved
Hide resolved
IbrahimCSAE
commented
Apr 9, 2024
| @@ -80,7 +81,9 @@ const PlanarFreehandROI = { | |||
| * @param {object} annotation | |||
| * @returns {object} Report's content from this tool | |||
| */ | |||
| function getColumnValueReport(annotation) { | |||
| function getColumnValueReport(annotation, customizationService) { | |||
| const { PlanarFreehandROI } = customizationService.get('cornerstone.measurements'); | |||
IbrahimCSAE
commented
Apr 9, 2024
| values.push(max, mean, stdDev, unit, area, areaUnit, perimeter); | ||
| const stats = data.cachedStats[`imageId:${metadata.referencedImageId}`]; | ||
|
|
||
| report.forEach(({ name, value }) => { |
IbrahimCSAE
commented
Apr 9, 2024
| @@ -122,19 +122,19 @@ function getColumnValueReport(annotation) { | |||
| * @param {Object} displaySet - The display set object. | |||
| * @returns {string[]} - An array of display text. | |||
| */ | |||
| function getDisplayText(annotation, displaySet) { | |||
| function getDisplayText(annotation, displaySet, customizationService) { | |||
| const { PlanarFreehandROI } = customizationService.get('cornerstone.measurements'); | |||
There was a problem hiding this comment.
custom display text
IbrahimCSAE
commented
Apr 9, 2024
| displayText.push(`Perimeter: ${perimeterValues.join(', ')} ${modalityUnit}`); | ||
| } else { | ||
| displayText.push(`Perimeter: ${utils.roundNumber(perimeter)} ${modalityUnit}`); | ||
| displayText.forEach(({ displayName, value, type }) => { |
sedghi
reviewed
Apr 9, 2024
| @@ -64,6 +64,136 @@ function getCustomizationModule() { | |||
| step: 1, | |||
| }, | |||
| }, | |||
| { | |||
| id: 'cornerstone.measurements', | |||
| Angle: { | |||
There was a problem hiding this comment.
please refactor in another file, we should call this something like cornerstone.measurementStatsDisplay or something
sedghi
approved these changes
Apr 10, 2024
thanh-nguyen-dang
pushed a commit
to uc-cdis/Viewers
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR has general bug fixes and enhancements
Changes & Results