-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(viewport): Reset viewport state and fix CINE looping, thumbnail resolution, and dynamic tool settings #4037
Conversation
…sx, OHIFCornerstoneSEGViewport.tsx, OHIFCornerstoneSRViewport.tsx, and TrackedCornerstoneViewport.tsx
…ment Tracking extensions
…ns.ts in segmentation
…DownRow.tsx, and SegmentationGroupTable.tsx
…ToolbarModule.tsx
…nd SegmentationGroupTable.tsx
…ved performance and readability
…or improved performance and readability
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4037 +/- ##
==========================================
- Coverage 46.23% 44.37% -1.87%
==========================================
Files 78 80 +2
Lines 1276 1334 +58
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 589 +41
- Partials 138 153 +15 ☔ View full report in Codecov by Sentry. |
Passing run #3832 ↗︎Details:
Review all test suite changes for PR #4037 ↗︎ |
…esolution, and dynamic tool settings (OHIF#4037)
💯 💯 💯 💯
This PR includes the addition of the OHIF DICOM Conformant Statement, generously made open source by Radical Imaging. We truly appreciate their contribution and dedication to open-source initiatives.
💯 💯 💯 💯
Context
Fixed reset of the viewports state when custom layout
After the user moves to a hanging protocol via presets (mpr, fourUp) there was no way to go back to simple stack viewport on drag and drop. This PR introduces a new state called
isHangingProtocolLayout
in viewportGrid where it makes the viewports start fresh if they are not in the hanging protocol mode**Fixed CINE playing infinitely **
Fixed low resolution thumbnails
Made Add New Segmentation and the MPR layouts dynamically re-calculated
adds ability to directly run commands in the tool settings of the toolbar buttons in your modes
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment