Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bugs): and replace seriesInstanceUID and seriesInstanceUIDs URL with seriesInstanceUIDs #4049

Merged
merged 10 commits into from
Apr 18, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 18, 2024

Breaking Change

URL param:
Previously there were two params that you could choose: seriesInstanceUID and seriesInstanceUIDs, they have been replaced with seriesInstanceUIDs so even if you would like to filter one series use ``seriesInstanceUIDs`

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit f089ed3
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66207d081e89ce00083f8dec
😎 Deploy Preview https://deploy-preview-4049--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit f089ed3
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66207d08aea42a00088bddc4
😎 Deploy Preview https://deploy-preview-4049--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE self-requested a review April 18, 2024 01:53
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sedghi sedghi changed the title 3p8 rc1 again fix(bugs): and replace seriesInstanceUID and seriesInstanceUIDs URL with seriesInstanceUIDs Apr 18, 2024
@sedghi sedghi merged commit da7c1a5 into master Apr 18, 2024
7 checks passed
Copy link

cypress bot commented Apr 18, 2024

Passing run #3848 ↗︎

0 43 0 0 Flakiness 0

Details:

Refactor toolbar event registration in cornerstone extension
Project: Viewers Commit: f089ed3e8f
Status: Passed Duration: 06:00 💡
Started: Apr 18, 2024 2:05 AM Ended: Apr 18, 2024 2:11 AM

Review all test suite changes for PR #4049 ↗︎

WillianVarela pushed a commit to cfaz-net/dicomviewer that referenced this pull request Apr 19, 2024
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants