-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hp): Fails to display any layouts in the layout selector if first layout has multiple stages #4058
Conversation
…out has multiple stages
✅ Deploy Preview for ohif-dev canceled.
|
✅ Deploy Preview for ohif-platform-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4058 +/- ##
==========================================
- Coverage 46.23% 44.41% -1.83%
==========================================
Files 78 80 +2
Lines 1276 1333 +57
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 588 +40
- Partials 138 153 +15 ☔ View full report in Codecov by Sentry. |
1 failed test on run #3854 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
OHIF Study List > Desktop resolution > maintains MRN filter upon return from viewer |
Test Replay
Screenshots
Video
|
Review all test suite changes for PR #4058 ↗︎
… layout has multiple stages (OHIF#4058)
… layout has multiple stages (OHIF#4058)
Context
If the first layout defined, and currently applied has more than one stage and the second or later stages is applied, then the layout selector throws an exception on attempting to change layouts.
Changes & Results
Just set the stage index to 0 on changing protocol
Testing
Use the URL
http://localhost:3000/basic-test?StudyInstanceUIDs=2.16.124.113543.6004.101.103.20021117.061159.1&hangingProtocolId=@ohif/mnGrid
on a yarn test:e2e:serve
Click comma to navigate to stage index 1 (2cd stage)
Try to change to 3x2 layout
Currently goes black with an exception, expected behaviour is to go to 3x2 layout.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment