fix(hydration): Maintain the same slice that the user was on pre hydration in post hydration for SR and SEG. #4200
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs canceled.
|
Passing run #4033 ↗︎
Details:
Review all test suite changes for PR #4200 ↗︎ |
|||||||||||||||
| }, | ||
| // { | ||
| // name: hpScale.id, | ||
| // protocol: hpScale, | ||
| // }, | ||
| { | ||
| name: hpScale.id, | ||
| protocol: hpScale, | ||
| }, |
There was a problem hiding this comment.
revert this for now since when you go to segmenttaion mode this gets matched for some reason
| if (viewportId === targetViewportId) { | ||
| viewport.viewportOptions.initialImageOptions = { | ||
| index: initialSliceIndex, | ||
| useOnce: true, |
There was a problem hiding this comment.
Why do we need useOnce? I don't prefer this approach.
There was a problem hiding this comment.
So when the seg is hydrated, the initial image index is set, but lets say the user switches to another series, then drops the referenced series for the seg again, we should not use the initial index again, we should default to first/middle or last.
| @@ -81,6 +86,29 @@ function TrackedMeasurementsContextProvider( | |||
| }, | |||
| }); | |||
| }, | |||
|
|
|||
| jumpToSameImageInActiveViewport: (ctx, evt) => { | |||
There was a problem hiding this comment.
Will this be the same logic if there is only one measurement? What I'm asking is, is jumpToSameImage = jumpToFirstMeasurement if there is only one measurement?
There was a problem hiding this comment.
It doesn’t matter how many measurements there are, it will still be the same slice the user was on
Context
Maintain the same slice that the user was on pre hydration in post hydration for SR and SEG.
Fixes #3884