Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): version txt had a new line which it should not #4233

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Jun 14, 2024

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 4ac7651
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66704561d8b608000964e929

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 4ac7651
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6670456126a0b60008dcde37

Copy link

cypress bot commented Jun 14, 2024

Passing run #4073 ↗︎

0 44 2 0 Flakiness 0

Details:

fix(pdf): build
Project: Viewers Commit: af29d42a42
Status: Passed Duration: 05:16 💡
Started: Jun 14, 2024 6:05 PM Ended: Jun 14, 2024 6:10 PM

Review all test suite changes for PR #4233 ↗︎

@sedghi sedghi merged commit 097ef76 into master Jun 17, 2024
5 of 7 checks passed
@sedghi sedghi deleted the fix/cli-dd branch January 22, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant