Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stdValue in TMTV mode #4278

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix: stdValue in TMTV mode #4278

merged 1 commit into from
Jul 4, 2024

Conversation

Celian-abd
Copy link
Contributor

Context

We find out that the stdValue return in the cachedStats for the segment in TMTV mode is wrong. We compared it with the same image and ROI and found two different result.

What we have:
image

What we should have :
image (1)

Changes & Results

  • Fix stdValue calulation
  • Optimize by calculating the mean only once

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 38509fe
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66851e3818d6e60008cb573d
😎 Deploy Preview https://deploy-preview-4278--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 38509fe
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66851e38cfedac0008fd1ab6
😎 Deploy Preview https://deploy-preview-4278--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title fix: stdValue in TMTV mode is wrong fix: stdValue in TMTV mode Jul 4, 2024
@sedghi sedghi merged commit b2c6291 into OHIF:master Jul 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants