Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dicom): Update multiframe DICOM JSON parsing for correct image ID generation #4307

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix(dicom): Update multiframe DICOM JSON parsing for correct image ID generation #4307

merged 2 commits into from
Jul 26, 2024

Conversation

igoroctaviano
Copy link
Contributor

@igoroctaviano igoroctaviano commented Jul 24, 2024 •
edited
Loading

Context

When loading a multiframe dicom json with multiple instances (each instance with its unique URL) OHIF was generating the image ids using just the first instance URL. Here I'm updating the parsing so it prioritizes the instances from the JSON file

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify Netlify
Copy link

netlify bot commented Jul 24, 2024 •
edited
Loading

✅ Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit dd78da4
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66a3cbbe57cdf10008c01325

@netlify Netlify
Copy link

netlify bot commented Jul 24, 2024 •
edited
Loading

✅ Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit dd78da4
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66a3cbbefa53ee0008b2028e

@igoroctaviano igoroctaviano changed the title WIP: Use json instances if present for multiframe Prioritize JSON multiframe instances if present Jul 24, 2024
@igoroctaviano igoroctaviano requested a review from sedghi July 24, 2024 20:38
sedghi
sedghi reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have test files that i can try before and after?

@cypress Cypress
Copy link

cypress bot commented Jul 24, 2024 •
edited
Loading

Passing run #4193 ↗︎

0 44 2 0 Flakiness 0

Details:

chore: Update DICOM JSON generator to support optional scheme parameter
Project: Viewers Commit: dd78da4496
Status: Passed Duration: 05:21 💡
Started: Jul 26, 2024 4:41 PM Ended: Jul 26, 2024 4:46 PM

Review all test suite changes for PR #4307 ↗︎

@sedghi sedghi changed the title Prioritize JSON multiframe instances if present fix(dicom): Update multiframe DICOM JSON parsing for correct image ID generation Jul 26, 2024
@sedghi sedghi merged commit 16b7aa4 into master Jul 26, 2024
14 checks passed
@sedghi sedghi deleted the fix/multiframe-json branch January 22, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedghi sedghi sedghi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igoroctaviano @sedghi