Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HangingProtocol): fix hp when unsupported series load first #4145

Merged

Conversation

Michael-Andersen
Copy link
Contributor

Context

When the first series in a study are an unsupported type (RTPLAN, REG, etc.) the first image series was not loading, double clicking the series would then cause a crash. This was discussed during May 16 office hours: https://github.com/OHIF/OHIF-Office-Hours/blob/main/notes/2024-05-16.md

Changes & Results

  • Added more unsupported modalities to the low priority list.
  • Removed .js low priority duplicate file
  • Removed minimum series requirement for hp start

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS: Windows 10
  • [] Node version: v16.17.0
  • [] Browser: Version 124.0.6367.119 (Official Build) (64-bit)

Copy link

netlify bot commented May 17, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit f5e33e5
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/664d2c126fb3e600083d7b01
😎 Deploy Preview https://deploy-preview-4145--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 17, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit f5e33e5
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/664d2c128d3f2100088e476d
😎 Deploy Preview https://deploy-preview-4145--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Michael-Andersen
Copy link
Contributor Author

@wayfarer3130 As discussed yesterday

@wayfarer3130
Copy link
Contributor

The PR failure looks like a real issue caused by changing how we sort things. We get a random ordering on split series - that is something I will try to fix and push to the PR

@wayfarer3130 wayfarer3130 merged commit b124c91 into OHIF:master May 21, 2024
6 checks passed
@wayfarer3130
Copy link
Contributor

The PR failure wasn't reproducible, so I think there is still a race condition onload somewhere, but not this issue's fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants