Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: customization types #4321

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

pedrokohler
Copy link
Collaborator

Context

Customization types do not match what already exists in custom components. Just fixing it so it comprises everything.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@pedrokohler pedrokohler requested a review from sedghi July 31, 2024 12:19
Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 957e91a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66aa2bb9ab473700085946c9
😎 Deploy Preview https://deploy-preview-4321--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 957e91a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66aa2bb9193b850008767795
😎 Deploy Preview https://deploy-preview-4321--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi merged commit 72bef63 into OHIF:master Jul 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants