44118: Change External #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add employee edits Add engagement edits Use extra_uuids object Update Change External webform
|
Hvis jeg loader en External ind og redigerer, idet jeg ændrer/tilføjer email-adresse, får jeg som afslutning på flowet denne fejlmeddelelse: "Unable to edit external employee: Missing uuid" Jeg prøver lige nogle flere ting. |
agger-magenta
suggested changes
Oct 14, 2021
Koden antager, at der allerede findes både et telefonnummer og en emailadresse, fordi det er påkrævet information under oprettelse af en external. Hvis de ikke findes i forvejen, skal der foregå en Create i stedet for Edit - og det vurderede jeg ikke var korrekt opførsel. |
|
OK, jeg tester lige med nogle nyere data. |
agger-magenta
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds the POST requests necessary to edit Externals in GIR from EGIR.
Note that information pertaining to cost centres and organisation units has been removed, because these should be included in move rather than change. They are only soft removed, i.e. hidden from the end user in the webform.