[#44119] Move External #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agger-magenta
force-pushed
the
44119_move_external
branch
from
4baabde to
359f8cc
Compare
agger-magenta
changed the title
nina-j
reviewed
Oct 18, 2021
| } | ||
| } | ||
| } | ||
| $form["elements"]["move_external"]["old_organizational_unit"]["#options"] = $org_unit_options; |
There was a problem hiding this comment.
Vi kommer til at blande double og single quotes lidt. Jeg tror nok Drupalstandarden siger single quotes med mindre man laver variable substitution. Det er dog ikke en bakke jeg vil dø på, blot en observation.
There was a problem hiding this comment.
Ja, du har ret: https://www.drupal.org/docs/develop/standards/coding-standards#quotes
Ser på det.
Co-authored-by: Nina <[email protected]>
agger-magenta
force-pushed
the
44119_move_external
branch
from
00838eb to
370c20a
Compare
nina-j
reviewed
Oct 19, 2021
nina-j
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
formAlterfunction on the employee webform handler which populates the options for the consultant's "old organization unit".