Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#44120] Move Many Externals #14

Merged
merged 6 commits into from
Oct 20, 2021
Merged

Conversation

agger-magenta
Copy link
Contributor

@agger-magenta agger-magenta commented Oct 18, 2021

Provide and populate a "checkboxes list" of externals in this org unit that can be moved.

Also ensure that submitForm is only invoked on first step of the form, which means that it is no longer necessary to have a condition on the form for this to work properly.

@agger-magenta agger-magenta force-pushed the 44120_move_many_externals branch from f34f184 to bc14c68 Compare October 19, 2021 11:14
@agger-magenta agger-magenta force-pushed the 44120_move_many_externals branch from 80d30f0 to c267a01 Compare October 19, 2021 13:52
@agger-magenta agger-magenta marked this pull request as ready for review October 20, 2021 08:30
@agger-magenta agger-magenta force-pushed the 44120_move_many_externals branch from 45231e9 to 3eded74 Compare October 20, 2021 08:32
@agger-magenta agger-magenta requested a review from nina-j October 20, 2021 09:03
Copy link
Contributor

@nina-j nina-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Der er noget noget galt med vores exceptions fra Keycloak auth fetcher, tror jeg:
image

Jeg har testet lokalt, og kan ikke umiddelbart få listen populeret. Min forståelse er, at vi skal flytte employment associations fra én unit til en anden, men når jeg slår units op med aktive associations op, bliver listen ikke populeret. Jeg har nogle test cases du kan efterprøve, hvis det er.

@nina-j
Copy link
Contributor

nina-j commented Oct 20, 2021

Jeg har testet lokalt, og kan ikke umiddelbart få listen populeret. Min forståelse er, at vi skal flytte employment associations fra én unit til en anden, men når jeg slår units op med aktive associations op, bliver listen ikke populeret. Jeg har nogle test cases du kan efterprøve, hvis det er.

Det virker helt som forventet efter genindlæsning af webformularen.

@nina-j nina-j self-requested a review October 20, 2021 10:56
@agger-magenta agger-magenta merged commit 36138a8 into main Oct 20, 2021
@agger-magenta agger-magenta deleted the 44120_move_many_externals branch October 20, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants