Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

44120: Move many externals #19

Merged
merged 1 commit into from
Nov 1, 2021
Merged

44120: Move many externals #19

merged 1 commit into from
Nov 1, 2021

Conversation

nina-j
Copy link
Contributor

@nina-j nina-j commented Oct 29, 2021

This MR adds the POST requests necessary to move many externals between organisation units in GIR from EGIR.

Since no date fields were provided in the webform, it is assumed that validity should be from the date the request is made. This can of course be changed if necessary.

Note that this code relies on #18 to be merged first.

@nina-j nina-j requested a review from agger-magenta October 29, 2021 14:27
Copy link
Contributor

@agger-magenta agger-magenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine apart from the single comment!

Add move many externals code

Update webform
@nina-j nina-j force-pushed the 44120-move-many-externals branch from 8124c3e to 31292cc Compare November 1, 2021 13:38
@nina-j nina-j marked this pull request as ready for review November 1, 2021 13:38
@nina-j nina-j merged commit 83133a4 into main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants