[45148] Make a better "library" structure #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agger-magenta
force-pushed
the
45293_refactor_libraries
branch
from
9f5dd1f to
28cb037
Compare
|
LGTM - jeg synes det er fint, at vi nu kan være eksplicitte omkring, hvor de forskellige funktioner kommer fra. Jeg har opdateret mange af de berørte filer i mit nuværende arbejde, så det kunne være fedt at få merged hurtigst muligt, så jeg kan få flyttet min kode rundt. |
nina-j
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jeg har lavet en refactor, hvor jeg inkluderer vores GIR-utils uden at skulle lave en eksplicit
requirenogen steder.Det er (i mine øjne) mere gennemskueligt. Som PHPs namespaces virker, var løsningen med en klasse med ene statiske funktioner så vidt jeg kan se den eneste løsning.