Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#45148: Lint files #6

Merged
merged 2 commits into from
Oct 7, 2021
Merged

#45148: Lint files #6

merged 2 commits into from
Oct 7, 2021

Conversation

nina-j
Copy link
Contributor

@nina-j nina-j commented Oct 6, 2021

lowerCamelCase hurts my eyes something awful but it had to be done!

@nina-j nina-j requested a review from agger-magenta October 6, 2021 14:21
agger-magenta
agger-magenta suggested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@agger-magenta agger-magenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, jeg er heller ikke fan af lowerCamel!

Det sagt, så er der filer under src/Plugin og src/Feeds, der kalder funktioner fra GIRUtils, som også skal rettes til.

@nina-j nina-j changed the title Lint files #45148: Lint files Oct 7, 2021
@nina-j nina-j merged commit 97d5b65 into main Oct 7, 2021
@nina-j nina-j deleted the phpcs-linting branch October 8, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agger-magenta agger-magenta agger-magenta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nina-j @agger-magenta