[Bug] OSGeo4w builds fail unable to locate PostgreSQL library

[echoix]

Describe the bug

Just noting that windows builds recently started failing on main and PRs, while they were working up to 7 hours ago. I don't see any commits in the OSGeo4W repo, so there must be changes that aren't pushed yet. Its harder to investigate since there is no observability in this case.

To reproduce

Our first broken run on main for commit ff7cebd: https://github.com/OSGeo/grass/actions/runs/12965370319

Our last working run on main for commit 1c956f7: https://github.com/OSGeo/grass/actions/runs/12953600166

There are more from the renovate PRs in between.

To investgate...

Further info (edits):

From an OSGeo installation that wasn't updated since a couple of weeks (max 3), we see libpq upgraded from 16.2-2 to 17.2-1.

But the package source file in the OSGeo4W repo is still 16.2 (last commit of the repo is from 2 weeks ago):
https://github.com/jef-n/OSGeo4W/blob/c6ba3d7a4e42753944ba3b5679b2298be69421a5/src/libpq/osgeo4w/package.sh#L1-L6

[echoix]

@jef-n Is it an expected situation caused by an update? If there's somewhere I could see the changes made, I could create the needed changes for here.

[nilason]

There was an update to 17.2: jef-n/OSGeo4W@83d7b6e

[echoix]

I see that some commits were recently pushed, but seemed committed a couple days before

[echoix]

@nilason look at the new patches for grass: jef-n/OSGeo4W@5469ac4#diff-414d394754c9be1f500a50bb84f57407a144af9b3ea204bc88b9c50245ce073eR23

[nilason]

This is what config.log has to say:

configure:11260: checking for location of PostgreSQL library
configure:11267: result: /c/OSGeo4W/lib
configure:11290: checking for PQsetdbLogin in -lpq
configure:11310: x86_64-w64-mingw32-gcc -o conftest.exe  -pipe    -I/c/OSGeo4W/include  -L/c/OSGeo4W/lib   -Wl,--export-dynamic,--enable-runtime-pseudo-reloc  -L/c/OSGeo4W/lib -L/c/OSGeo4W/bin conftest.c -lpq   >&5
D:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/14.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: warning: --export-dynamic is not supported for PE+ targets, did you mean --export-all-symbols?
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
D:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/14.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:/OSGeo4W/lib/libpq.a(src/interfaces/libpq/libpq.a.p/fe-connect.c.obj):(.text$mn+0x40): undefined reference to `__security_cookie'
D:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/14.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:/OSGeo4W/lib/libpq.a(src/interfaces/libpq/libpq.a.p/fe-connect.c.obj):(.text$mn+0x2a9): undefined reference to `pg_snprintf'
...

See this SO post for possible cause.

config.log