Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NestBot app home section and commands code #428

Closed
arkid15r opened this issue Jan 12, 2025 · 4 comments · Fixed by #479
Closed

Refactor NestBot app home section and commands code #428

arkid15r opened this issue Jan 12, 2025 · 4 comments · Fixed by #479
Assignees
Labels

Comments

@arkid15r
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently we have some code duplication for NestBot app home page actions and commands, e.g. 1 and 2, or 3 and 4

Describe the solution you'd like
Extract and extend slack/commands/* code for chapters, committees, contribute, projects into slack/common/* files and reuse it for both app home page and commands. Make sure to add a params to control entity summary length (truncation) and other presentation parts that may need to look different. Unify the code and the entities end user's look.

@github-project-automation github-project-automation bot moved this to Backlog in Project Nest Jan 12, 2025
@arkid15r arkid15r moved this from Backlog to Todo in Project Nest Jan 12, 2025
@AbhayTopno
Copy link
Collaborator

@arkid15r can you assign thia to me please

@nitinawari
Copy link
Collaborator

nitinawari commented Jan 12, 2025

@arkid15r can i work on this ? I recently implementated to command i have idea about it

@nitinawari
Copy link
Collaborator

@arkid15r I’ve completed this task, but there’s an overlap with #427 after extracting the common command code into common/handlers.py.

As discussed with @AbhayTopno in Slack DMs, He handling that task and would like to complete it. Should I avoid extracting the contribution-related code to prevent conflicts?

Also, do you think handlers.py is a good name for the common file, or would you suggest a more descriptive alternative?

@arkid15r
Copy link
Collaborator Author

Yes, let's deal w/ the contribute command later.
Please submit the code and I'll be able to suggest better naming if possible.

Thank you @nitinawari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants