-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor NestBot app home section and commands code #428
Comments
@arkid15r can you assign thia to me please |
@arkid15r can i work on this ? I recently implementated to command i have idea about it |
@arkid15r I’ve completed this task, but there’s an overlap with #427 after extracting the common command code into As discussed with @AbhayTopno in Slack DMs, He handling that task and would like to complete it. Should I avoid extracting the contribution-related code to prevent conflicts? Also, do you think |
Yes, let's deal w/ the contribute command later. Thank you @nitinawari |
Is your feature request related to a problem? Please describe.
Currently we have some code duplication for NestBot app home page actions and commands, e.g. 1 and 2, or 3 and 4
Describe the solution you'd like
Extract and extend
slack/commands/*
code for chapters, committees, contribute, projects intoslack/common/*
files and reuse it for both app home page and commands. Make sure to add a params to control entity summary length (truncation) and other presentation parts that may need to look different. Unify the code and the entities end user's look.The text was updated successfully, but these errors were encountered: